"Save Sorting" not working with "Level %"

[Greysteele]

I reported this months ago, but it seems to keep falling off the to-do list...

If you select "Level %" (that's Level PERCENT, not just Level) and then click on "Save Sorting", it says "Characters now set to sort by the LEVEL column".  And it does just that - sorts by the LEVEL column instead of the LEVEL PERCENT column. 

This problem is caused by the wrong ID being used on the column header label:
   
   <thead>
      <tr>
         <th id="faction">Fac</th>
         <th id="origin">Or</th>
         <th id="archetype">Ar</th>
         <th id="hidden">Hide</th>
         <th id="image">Img</th>
         <th id="flag">Flag</th>
         <th id="name">Name</th>
         <th id="level">Level</th>
         <th id="server">Server</th>
         <th id="primary">Primary</th>
         <th id="secondary">Secondary</th>
         <th id="offline">Days Offline</th>
         <th id="level">Lvl %</th>
         <th id="badges">Badges</th>
         <th>Actions</th>
      </tr>
   </thead>
         
Fixing that typo may not fix the problem, but it is definitely a start...

[Steiner]

You're quite right. however Luckily for us. jQuery (the javascript frame work used for that) just recently had an upgrade. I can sort by the data within the tags now... won't have to worry about id's and attributes before the actual info.

Putting on my personal task list. Quick fix.

[Greysteele]

BTW, this still isn't working right.  Oddly enough, when you sort by level pct and then click "Save Sorting", it says that it is "... now set to sort by the level_percent column" (which is a partial improvement), BUT it still doesn't actually save that sort setting.  I can do a refresh and it sorted differently- Looks like alpha by toon name.

[Steiner]

hmmm... I just thought it threw the column name in there... must be some logic to the code I was unaware of. I'll check it out.

[SaintNicster]

BTW, this still isn't working right.  Oddly enough, when you sort by level pct and then click "Save Sorting", it says that it is "... now set to sort by the level_percent column" (which is a partial improvement), BUT it still doesn't actually save that sort setting.  I can do a refresh and it sorted differently- Looks like alpha by toon name.

I'm working this one, to "give Steiner a break".  I think I've got it, just need to figure out one thing

[SaintNicster]

I'm working this one, to "give Steiner a break".  I think I've got it, just need to figure out one thing

Steiner pushed the code this morning.  Can you try sorting the "level percent" column, saving, then reloading the page to confirm for me?

[BlindFaith]

Anybody think about fixing the actual percentages? The current level is fine, but the numbers over 100% are incorrect. They are a simple percentage of the level target that you just completed, not the new one(s). I know this will be low priority, but I have not seen anyone mention it before...

[SaintNicster]

Anybody think about fixing the actual percentages? The current level is fine, but the numbers over 100% are incorrect. They are a simple percentage of the level target that you just completed, not the new one(s). I know this will be low priority, but I have not seen anyone mention it before...

I've always thought of it as an indicator of "Man, I really need to train this toon".  Plus it is funny to see a character with 500%+ of the required XP needed.

[BlindFaith]

It's really funny to have 856% and only need to train 3 levels...

[Greysteele]

SaintNicster, this is partially fixed.  It will save a sort by the Level Percent column, but only ascending, not descending.

Getting there...

[SaintNicster]

SaintNicster, this is partially fixed.  It will save a sort by the Level Percent column, but only ascending, not descending.

Getting there...

hurm...

*dives back in*

[Tazhyngarth]

Need this?

# $sort_direction.', name des, server_name des';
# $sort_direction = '';

[Steiner]

stab the type-o monkey!

[SaintNicster]

*thwaps the code upside the head*

Working now.  Helps if I commit the right copy of the code >.>

[Greysteele]

Mooch ass grassy ass, scene your!

Sorry... Still recovering from Cinco de mayo.

That got it.  Fixed.